Revert "RUM-1002 Implement base64 for imageviews"#1655
Merged
Conversation
This reverts commit 3100b41.
Codecov Report
@@ Coverage Diff @@
## release/2.2.0 #1655 +/- ##
=================================================
- Coverage 83.86% 83.80% -0.06%
=================================================
Files 456 457 +1
Lines 15692 15731 +39
Branches 2346 2348 +2
=================================================
+ Hits 13160 13183 +23
- Misses 1922 1924 +2
- Partials 610 624 +14
|
0xnm
approved these changes
Oct 3, 2023
xgouchet
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3100b41.
Reverts base64 imageview support due to an issue discovered where the "content image" square size would change between when the image begins to download and finishes downloading remotely (the image is resized for centercrop). We will need to implement wireframe cropping and keep the image at a constant size.
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)