RUM-1208: Target Android 14 (API 34)#1649
Merged
Merged
Conversation
0xnm
marked this pull request as ready for review
September 29, 2023 10:24
0xnm
force-pushed
the
nogorodnikov/rum-1208/target-android-14
branch
from
September 29, 2023 10:52
e11e265 to
b5cdc02
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1649 +/- ##
===========================================
- Coverage 83.72% 83.64% -0.09%
===========================================
Files 456 456
Lines 15690 15687 -3
Branches 2345 2344 -1
===========================================
- Hits 13136 13120 -16
- Misses 1927 1932 +5
- Partials 627 635 +8 🚀 New features to boost your workflow:
|
xgouchet
approved these changes
Sep 29, 2023
mariusc83
approved these changes
Sep 29, 2023
| } | ||
|
|
||
| unMock { | ||
| keep("android.widget.ImageView\$ScaleType") |
Member
Author
There was a problem hiding this comment.
otherwise running unit test fails, because probably android.jar for API 34 changed behaviour of ScaleType.values() which returns null and then when branch fails to process this value in the getDrawableScaledDimensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Behaviour changes are here https://developer.android.com/about/versions/14/behavior-changes-14.
Review checklist (to be filled by reviewers)