feat: Add isEnabled to Logs#1648
Merged
Merged
Conversation
fuzzybinary
force-pushed
the
jward/isEnabled
branch
2 times, most recently
from
September 28, 2023 19:26
194afab to
0cfa80c
Compare
xgouchet
approved these changes
Sep 29, 2023
0xnm
reviewed
Sep 29, 2023
| */ | ||
| @JvmOverloads | ||
| @JvmStatic | ||
| fun isEnabled(sdkCore: SdkCore = Datadog.getInstance()): Boolean { |
Member
There was a problem hiding this comment.
Seems like implementation is different from iOS, where this method is public, but is still in the internal extension? Here we expose it directly, without any proxies.
Member
Author
There was a problem hiding this comment.
Yes, I can make it internal but I based the decision based on the documentation on GlobalRumMonitor. I figured Android might have more of a need for such a method than iOS, but if you think not so much I can make the internal proxy.
Member
There was a problem hiding this comment.
I'm ok with having it as public, just was curious about the consistency of public API with iOS.
0xnm
approved these changes
Sep 29, 2023
fuzzybinary
force-pushed
the
jward/isEnabled
branch
from
September 29, 2023 15:34
0cfa80c to
0049d35
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1648 +/- ##
===========================================
+ Coverage 83.68% 83.76% +0.07%
===========================================
Files 456 456
Lines 15690 15692 +2
Branches 2345 2346 +1
===========================================
+ Hits 13130 13143 +13
+ Misses 1931 1928 -3
+ Partials 629 621 -8
|
Method is needed to properly setup Flutter when using `attachToExisting`. refs: RUM-1066
fuzzybinary
force-pushed
the
jward/isEnabled
branch
from
September 29, 2023 16:44
0049d35 to
d7f5692
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a static method to Logs for checking if the feature had been enabled in a core. This method is needed to properly setup Flutter when using
attachToExisting.refs: RUM-1066
Review checklist (to be filled by reviewers)