Update functional tests due to imageview support#1646
Merged
jonathanmos merged 1 commit intoSep 28, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1646 +/- ##
===========================================
- Coverage 83.68% 83.66% -0.02%
===========================================
Files 456 456
Lines 15696 15696
Branches 2347 2347
===========================================
- Hits 13135 13132 -3
- Misses 1927 1930 +3
Partials 634 634 |
jonathanmos
force-pushed
the
jmoskovich/update-functional-tests-imageviews
branch
from
September 28, 2023 11:17
c191443 to
b008f06
Compare
mariusc83
approved these changes
Sep 28, 2023
jonathanmos
deleted the
jmoskovich/update-functional-tests-imageviews
branch
September 28, 2023 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the jsons for images/textviews due to the changes in the imageview support pr.
• EditText no longer have underline from a shape
• ImageViews are supported, so base64 and no longer shapes
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)