Conversation
…e from user/feature settings
Codecov Report
@@ Coverage Diff @@
## develop #1643 +/- ##
===========================================
- Coverage 83.65% 83.64% -0.00%
===========================================
Files 456 456
Lines 15703 15700 -3
Branches 2342 2341 -1
===========================================
- Hits 13135 13132 -3
- Misses 1937 1940 +3
+ Partials 631 628 -3
|
xgouchet
approved these changes
Sep 27, 2023
jonathanmos
approved these changes
Sep 27, 2023
0xnm
deleted the
nogorodnikov/rum-1202/make-featurefileorchestrator-use-persistence-config-from-user-settings
branch
September 27, 2023 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It turns out that
FeatureFileOrchesratorwas using default file persistence config which didn't reflect user settings and feature settings for batch size, max item size, etc. This PR fixes it.Review checklist (to be filled by reviewers)