RUM-1187 Add more information into the batch telemetry#1641
Conversation
2450355 to
876f439
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1641 +/- ##
===========================================
+ Coverage 83.79% 83.82% +0.03%
===========================================
Files 455 455
Lines 15684 15697 +13
Branches 2333 2336 +3
===========================================
+ Hits 13142 13158 +16
- Misses 1918 1924 +6
+ Partials 624 615 -9
|
cbdb6b4 to
e359fe4
Compare
e359fe4 to
5790972
Compare
| /* The value for the type of the metric.*/ | ||
| internal const val BATCH_CLOSED_TYPE_VALUE = "batch closed" | ||
|
|
||
| /* The value of the tracking consent according with this file origin.*/ |
There was a problem hiding this comment.
| /* The value of the tracking consent according with this file origin.*/ | |
| /* The tracking consent according to the file origin.*/ |
| internal const val FILE_NAME = "name" | ||
|
|
||
| /* The thread name from which the current metric was sent.*/ | ||
| internal const val THREAD_NAME = "thread" |
There was a problem hiding this comment.
minor: are these key names taken from a telemetry rfc doc? If we have flexibility it may be better to have more explicit map keys (e.g. it looks like we're sending a semiambiguous name in the map, where it might be preferable to send filename, and to a lesser extent for thread/threadname). wdyt?
There was a problem hiding this comment.
wanted to use a shorter key for having lighter logs but yeah...3 chars will not kill
0xnm
left a comment
0xnm
left a comment
There was a problem hiding this comment.
lgtm! I've added one suggestions
|
|
||
| companion object { | ||
|
|
||
| internal val IS_GRANTED_DIR_REG_EX = Regex("[a-z]+-v[0-9]+") |
There was a problem hiding this comment.
should we move this to the FeatureFileOrchestrator? At least this way if we update naming convention for the folders we won't forget to update this one as well.
There was a problem hiding this comment.
actually this is not good enough :)...need to find a better one. We also have session-replay-v1 or ndk_crash_reports_intermediary-v1
75bd1eb to
938ab50
Compare
| internal const val PENDING_DIR = "%s-pending-v$VERSION" | ||
| internal const val PENDING_DIR_SUFFIX = "-pending-v$VERSION" | ||
| internal const val PENDING_DIR = "%s$PENDING_DIR_SUFFIX" |
There was a problem hiding this comment.
it seems that this change can be reverted
938ab50 to
d64d0d6
Compare
| ) | ||
|
|
||
| companion object { | ||
| private const val BASE_DIR_NAME_REG_EX = "([a-z]+[-|_])+" |
There was a problem hiding this comment.
Do we have a list of base dire name used? It seems this regex is allowing a lot more than it should (e.g.: abcdef|)
5 participants
What does this PR do?
Following the latest discussions regarding the problem with the batch telemetry data for Android SDK we decided to add more information into the related logs:
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)