RUM-938 Implement heuristic image classification#1640
Merged
jonathanmos merged 1 commit intoSep 27, 2023
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-938/implement-image-classification
branch
from
September 26, 2023 07:47
195cdf5 to
7f5d08b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1640 +/- ##
===========================================
+ Coverage 83.71% 83.77% +0.05%
===========================================
Files 456 457 +1
Lines 15713 15735 +22
Branches 2339 2344 +5
===========================================
+ Hits 13154 13181 +27
- Misses 1927 1930 +3
+ Partials 632 624 -8
|
jonathanmos
force-pushed
the
jmoskovich/rum-938/implement-image-classification
branch
2 times, most recently
from
September 26, 2023 11:38
8e3d083 to
62d78d7
Compare
mariusc83
requested changes
Sep 26, 2023
jonathanmos
marked this pull request as ready for review
September 26, 2023 12:51
mariusc83
previously approved these changes
Sep 26, 2023
0xnm
approved these changes
Sep 27, 2023
mariusc83
approved these changes
Sep 27, 2023
jonathanmos
force-pushed
the
jmoskovich/rum-938/implement-image-classification
branch
from
September 27, 2023 11:29
c370b54 to
ecac21d
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-938/implement-image-classification
branch
from
September 27, 2023 11:36
ecac21d to
6267858
Compare
jonathanmos
deleted the
jmoskovich/rum-938/implement-image-classification
branch
September 27, 2023 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement a heuristic image classification to determine whether an image is PII or not. If the image is PII then send a placeholder wireframe identifying the image as a content image.
The identification is by checking that the dimensions of the image do not exceed 48dp (the largest icon in the material design guidelines). In the case of GradientDrawable we ignore this check, since GradientDrawables cannot be PII and constitute the backgrounds for RippleDrawables.
Motivation
Avoid sending PII as part of base64.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)