RUM-391 use networkInfoEnabled to serialize or not network info in spans#1637
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## xgouchet/RUM-391/1_trace_network_info #1637 +/- ##
=========================================================================
+ Coverage 83.68% 83.75% +0.07%
=========================================================================
Files 456 456
Lines 15715 15720 +5
Branches 2338 2339 +1
=========================================================================
+ Hits 13150 13165 +15
+ Misses 1940 1929 -11
- Partials 625 626 +1
|
mariusc83
previously approved these changes
Sep 25, 2023
0xnm
previously approved these changes
Sep 26, 2023
Base automatically changed from
xgouchet/RUM-391/1_trace_network_info
to
develop
September 26, 2023 09:25
xgouchet
dismissed stale reviews from 0xnm and mariusc83
September 26, 2023 09:25
The base branch was changed.
0xnm
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
networkInfoEnabledto decide whether network info should be serialized or not in spansMotivation
This is part of several PRs to allow enabling/disabling attaching network info in spans collected in an Android app