RUM-391 make network info optional in span schema#1635
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1635 +/- ##
===========================================
- Coverage 83.72% 83.64% -0.07%
===========================================
Files 456 456
Lines 15716 15713 -3
Branches 2340 2339 -1
===========================================
- Hits 13157 13143 -14
- Misses 1927 1934 +7
- Partials 632 636 +4 |
xgouchet
force-pushed
the
xgouchet/RUM-391/0_trace_network_info
branch
from
September 23, 2023 08:46
6e245fa to
56c1d47
Compare
jonathanmos
approved these changes
Sep 24, 2023
0xnm
approved these changes
Sep 26, 2023
xgouchet
force-pushed
the
xgouchet/RUM-391/0_trace_network_info
branch
from
September 26, 2023 08:24
56c1d47 to
de15783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the network info optional in the span schema.
Motivation
This is part of several PRs to allow enabling/disabling attaching network info in spans collected in an Android app