RUM-1034 Add cross platform graphql attributes#1631
Merged
louiszawadzki merged 2 commits intoSep 22, 2023
Merged
Conversation
louiszawadzki
force-pushed
the
louiszawadzki/RUM-1034/add-cross-platform-graphql-attributes
branch
3 times, most recently
from
September 21, 2023 08:34
41f6f64 to
9b2d212
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1631 +/- ##
===========================================
- Coverage 83.77% 83.70% -0.07%
===========================================
Files 452 452
Lines 15674 15696 +22
Branches 2331 2336 +5
===========================================
+ Hits 13130 13138 +8
- Misses 1917 1937 +20
+ Partials 627 621 -6
|
louiszawadzki
marked this pull request as ready for review
September 21, 2023 09:11
0xnm
previously approved these changes
Sep 21, 2023
| } | ||
|
|
||
| @Test | ||
| fun `𝕄 use graphql timings 𝕎 handleEvent`( |
Member
There was a problem hiding this comment.
Suggested change
| fun `𝕄 use graphql timings 𝕎 handleEvent`( | |
| fun `𝕄 use graphql attributes 𝕎 handleEvent`( |
louiszawadzki
force-pushed
the
louiszawadzki/RUM-1034/add-cross-platform-graphql-attributes
branch
from
September 21, 2023 11:39
9b2d212 to
6b0e7ea
Compare
0xnm
approved these changes
Sep 21, 2023
xgouchet
approved these changes
Sep 21, 2023
louiszawadzki
deleted the
louiszawadzki/RUM-1034/add-cross-platform-graphql-attributes
branch
September 22, 2023 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable cross platform SDKs to specify GraphQL attributes.
We remove all cross-platform attributes first, and only add the graphql object if the operation type is present.
The implementation might change in the future when we support GraphQL requests monitoring for Android, but it should not be hard to migrate the cross platform SDKs then.
Motivation
Support GraphQL for cross platform SDKs
Review checklist (to be filled by reviewers)