RUM-1006 Add SR functional tests for ImageButtons and ImageViews#1630
Merged
mariusc83 merged 1 commit intoSep 22, 2023
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-1064/fix-the-base64-image-resolver-logic
branch
3 times, most recently
from
September 20, 2023 12:29
519310a to
a9b96c3
Compare
Base automatically changed from
mconstantin/rum-1064/fix-the-base64-image-resolver-logic
to
develop
September 20, 2023 13:01
mariusc83
force-pushed
the
mconstantin/rum-1006/sr-add-functional-tests-for-images-and-icons
branch
from
September 20, 2023 13:49
829c86d to
77d736c
Compare
mariusc83
force-pushed
the
mconstantin/rum-1006/sr-add-functional-tests-for-images-and-icons
branch
from
September 20, 2023 13:51
77d736c to
2e4f3b9
Compare
mariusc83
marked this pull request as ready for review
September 20, 2023 13:52
0xnm
approved these changes
Sep 22, 2023
| // in the process of being removed. This creates an issue with our SR recorder which | ||
| // calls the WindowInspector.getGlobalWindowViews() which can return the previous window + | ||
| // the current window and alters the tests. | ||
| Thread.sleep(2000) |
Member
There was a problem hiding this comment.
Interesting thing is that ActivityTestRule we are using is deprecated and the proposed replacement is ActivityScenarioRule which have a better control over the lifecycle by providing moveToState blocking methods. Maybe we should consider the possibility of migrating to ActivityScenarioRule later.
Codecov Report
@@ Coverage Diff @@
## develop #1630 +/- ##
===========================================
+ Coverage 83.81% 83.86% +0.05%
===========================================
Files 455 455
Lines 15686 15683 -3
Branches 2331 2330 -1
===========================================
+ Hits 13147 13152 +5
- Misses 1916 1918 +2
+ Partials 623 613 -10 |
mariusc83
deleted the
mconstantin/rum-1006/sr-add-functional-tests-for-images-and-icons
branch
September 22, 2023 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)