RUM-985 Add sampler to WebViewLogEventConsumer#1629
Merged
Conversation
0xnm
reviewed
Sep 20, 2023
Base automatically changed from
xgouchet/RUM-985/3_fix_webview_sample_app
to
xgouchet/RUM-985/2_use_native_sampling_webview_rum
September 20, 2023 08:32
xgouchet
force-pushed
the
xgouchet/RUM-985/4_use_sampling_webview_logs
branch
from
September 20, 2023 09:06
038794d to
16ecf7c
Compare
Base automatically changed from
xgouchet/RUM-985/2_use_native_sampling_webview_rum
to
develop
September 20, 2023 09:11
Codecov Report
@@ Coverage Diff @@
## develop #1629 +/- ##
===========================================
+ Coverage 83.59% 83.64% +0.05%
===========================================
Files 452 452
Lines 15664 15675 +11
Branches 2330 2332 +2
===========================================
+ Hits 13093 13110 +17
+ Misses 1952 1938 -14
- Partials 619 627 +8
|
mariusc83
previously approved these changes
Sep 21, 2023
jonathanmos
previously approved these changes
Sep 21, 2023
0xnm
reviewed
Sep 21, 2023
xgouchet
dismissed stale reviews from jonathanmos and mariusc83
via
September 21, 2023 13:29
249896d
0xnm
previously approved these changes
Sep 21, 2023
| internal val userLogsWriter: DataWriter<JsonObject>, | ||
| private val rumContextProvider: WebViewRumEventContextProvider | ||
| private val rumContextProvider: WebViewRumEventContextProvider, | ||
| private val sampleRate: Float |
Member
There was a problem hiding this comment.
It seems we don't need it even as a property if I'm not wrong.
Suggested change
| private val sampleRate: Float | |
| sampleRate: Float |
0xnm
approved these changes
Sep 21, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a setting to set the logs sample rate for Webview Logs integration