RUM-985 Only send Webview RUM events when Native Session exists and is tracked#1626
Merged
xgouchet merged 3 commits intoSep 20, 2023
Merged
Conversation
0xnm
previously approved these changes
Sep 20, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1626 +/- ##
===========================================
+ Coverage 83.67% 83.73% +0.06%
===========================================
Files 452 452
Lines 15660 15667 +7
Branches 2327 2331 +4
===========================================
+ Hits 13102 13118 +16
+ Misses 1937 1930 -7
+ Partials 621 619 -2
🚀 New features to boost your workflow:
|
Base automatically changed from
xgouchet/RUM-985/1_propagate_rum_context_as_string
to
develop
September 20, 2023 08:32
xgouchet
dismissed stale reviews from mariusc83 and 0xnm
September 20, 2023 08:32
The base branch was changed.
…sample_app RUM-985 fix the WebView fragment in sample app
0xnm
approved these changes
Sep 20, 2023
xgouchet
deleted the
xgouchet/RUM-985/2_use_native_sampling_webview_rum
branch
September 20, 2023 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The rule is that a browser RUM session should be tracked as part of the host application's session. This means that if the native session is not tracked, or if the RUM feature is not enabled, then the webview RUM events should be dropped.