RUM-886 Provide session replay data in configuration telemetry#1611
Conversation
4584101 to
e22c4df
Compare
6751fe7 to
8cc72eb
Compare
| val sessionReplayFeatureContext = | ||
| sdkCore.getFeatureContext(Feature.SESSION_REPLAY_FEATURE_NAME) | ||
| val sessionReplaySampleRate = sessionReplayFeatureContext[SESSION_REPLAY_SAMPLE_RATE_KEY] | ||
| ?.let { it as? Long } |
There was a problem hiding this comment.
why do we need let? we should be able to write as sessionReplayFeatureContext[SESSION_REPLAY_SAMPLE_RATE_KEY] as? Long and I guess the result should be the same? same for the lines below.
There was a problem hiding this comment.
oh yeah, of course, was a left over from previous implementation
| private val sampleRate: Float, | ||
| private val rateBasedSampler: Sampler, |
There was a problem hiding this comment.
it is kind of duplication of the same. normally we should be able to get sample rate from rateBasedSampler.getSampleRate
There was a problem hiding this comment.
yes but for that I need to cast the sampler to RateBasedSampler and I want to avoid that
There was a problem hiding this comment.
No, getSampleRate is a method of Sampler interface, no case is needed.
There was a problem hiding this comment.
oh ...didn't check that, good one ;)
8cc72eb to
5416510
Compare
5416510 to
2f00733
Compare
2f00733 to
c0a7f5a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1611 +/- ##
===========================================
+ Coverage 83.63% 83.68% +0.05%
===========================================
Files 451 451
Lines 15567 15557 -10
Branches 2318 2317 -1
===========================================
Hits 13018 13018
+ Misses 1930 1915 -15
- Partials 619 624 +5
|
4 participants
What does this PR do?
In this PR we are adding the information for the Session Replay feature configuration in our related Telemetry event.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)