RUM-1004 Add the SR functional tests for checkboxes and radiobuttons#1609
Merged
mariusc83 merged 1 commit intoSep 14, 2023
Conversation
mariusc83
marked this pull request as draft
September 8, 2023 08:33
mariusc83
force-pushed
the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
3 times, most recently
from
September 8, 2023 08:58
4645932 to
a56fcc6
Compare
mariusc83
marked this pull request as ready for review
September 8, 2023 09:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1609 +/- ##
===========================================
+ Coverage 83.57% 83.64% +0.06%
===========================================
Files 452 452
Lines 15652 15652
Branches 2324 2324
===========================================
+ Hits 13081 13091 +10
+ Misses 1950 1939 -11
- Partials 621 622 +1 🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
Sep 8, 2023
| import org.junit.Rule | ||
| import org.junit.Test | ||
|
|
||
| internal class SrCheckBoxAndRadioFieldsAllowTest : |
Member
There was a problem hiding this comment.
let's use SessionReplay in naming instead of Sr.
using just Sr will give many false-positives if text search is performed.
Member
Author
There was a problem hiding this comment.
Actually wanted to do this but if I do it I need to do it for all the classes there and some of them will be way too long 😮💨
mariusc83
force-pushed
the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
from
September 8, 2023 13:27
a56fcc6 to
99234bd
Compare
0xnm
previously approved these changes
Sep 8, 2023
mariusc83
force-pushed
the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
2 times, most recently
from
September 8, 2023 15:27
fd75c76 to
c58fb7b
Compare
0xnm
approved these changes
Sep 11, 2023
mariusc83
force-pushed
the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
from
September 14, 2023 12:19
c58fb7b to
8126315
Compare
mariusc83
force-pushed
the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
from
September 14, 2023 14:59
8126315 to
b6a2170
Compare
mariusc83
deleted the
mconstantin/rum-1004/sr-add-functional-tests-for-checkbox-and-radio-buttons
branch
September 14, 2023 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)