Skip to content

Fix Android Studio 'Rebuild Project'#1602

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/fix_AS_rebuild
Sep 6, 2023
Merged

Fix Android Studio 'Rebuild Project'#1602
xgouchet merged 1 commit into
developfrom
xgouchet/fix_AS_rebuild

Conversation

@xgouchet

@xgouchet xgouchet commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Android Studio's Rebuild Project button performs the equivalent of ./gradlew clean assemble. Because of that the genDir folder used to store json2kotlin generated files is cleared and doesn't exists when the GenerateApiSurfaceTaskis ran.

The recommended way is to store path instead of actual files when the file is not guaranteed to exists when the task is ran.

Motivation

Being able to use the Rebuild Project feature in AS.

@xgouchet
xgouchet requested a review from a team as a code owner September 6, 2023 11:53
@codecov-commenter

codecov-commenter commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (bf9b6c3) to head (cea3775).
Report is 2053 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1602      +/-   ##
===========================================
- Coverage    83.58%   83.45%   -0.13%     
===========================================
  Files          443      443              
  Lines        15122    15122              
  Branches      2264     2264              
===========================================
- Hits         12639    12620      -19     
- Misses        1885     1896      +11     
- Partials       598      606       +8     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet
xgouchet merged commit e79eb19 into develop Sep 6, 2023
@xgouchet
xgouchet deleted the xgouchet/fix_AS_rebuild branch September 6, 2023 12:31
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants