Skip to content

Base64 feature branch integration#1597

Merged
jonathanmos merged 17 commits into
developfrom
feature/base64-jmoskovich
Sep 5, 2023
Merged

Base64 feature branch integration#1597
jonathanmos merged 17 commits into
developfrom
feature/base64-jmoskovich

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

Merges the base64 feature branch into develop

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

…aching

REPLAY-1727: Base64 Caching Mechanism
…wnscaling

REPLAY- 1893: Implement bitmap downscaling
REPLAY-1890: Implement pool of reusable bitmaps
…-cache-singletons

REPLAY-1943: Refactor caches from singletons to class instances
Get Bitmap from BitmapDrawable if available
Extract base64 logic from mapper to ImageWireframeHelper
Get background images if they exist
Support scaletypes
…-bitmapdrawable

REPLAY-1891: Optimize bitmap processing
# Conflicts:
#	features/dd-sdk-android-session-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/async/RecordedDataQueueHandlerTest.kt
…extviews

RUM-936: Serialize TextViews/Buttons to base64
…velop

Align the base64 feature branch with develop
@jonathanmos
jonathanmos requested a review from a team as a code owner September 4, 2023 15:29
@codecov-commenter

codecov-commenter commented Sep 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1597 (fb8e426) into develop (1dfff18) will increase coverage by 0.14%.
The diff coverage is 88.27%.

@@             Coverage Diff             @@
##           develop    #1597      +/-   ##
===========================================
+ Coverage    83.55%   83.69%   +0.14%     
===========================================
  Files          443      451       +8     
  Lines        15135    15563     +428     
  Branches      2265     2318      +53     
===========================================
+ Hits         12646    13025     +379     
- Misses        1890     1919      +29     
- Partials       599      619      +20     
Files Changed Coverage Δ
...sionreplay/material/MaskInputTabWireframeMapper.kt 0.00% <ø> (ø)
...d/sessionreplay/material/MaskTabWireframeMapper.kt 100.00% <ø> (ø)
...replay/internal/recorder/wrappers/BitmapWrapper.kt 20.00% <ø> (ø)
...ndroid/sessionreplay/internal/utils/Base64Utils.kt 66.67% <0.00%> (ø)
...android/sessionreplay/internal/utils/CacheUtils.kt 15.79% <15.79%> (ø)
...id/sessionreplay/internal/recorder/base64/Cache.kt 25.00% <25.00%> (ø)
...eplay/internal/recorder/base64/BitmapPoolHelper.kt 62.50% <62.50%> (ø)
...nreplay/internal/recorder/base64/Base64LRUCache.kt 76.74% <76.74%> (ø)
...ionreplay/internal/recorder/mapper/ButtonMapper.kt 87.50% <80.00%> (-12.50%) ⬇️
...eplay/internal/recorder/base64/Base64Serializer.kt 84.52% <85.45%> (-5.27%) ⬇️
... and 15 more

... and 18 files with indirect coverage changes

Integrate latest changes from develop into base64 feature
@jonathanmos
jonathanmos merged commit aa1c2e1 into develop Sep 5, 2023
@jonathanmos
jonathanmos deleted the feature/base64-jmoskovich branch September 5, 2023 07:52
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants