what are the start/top/end/bottom coordinates of the compound drawable? what do they describe?

It describes the absolute positions of the drawables surrounding the TextView

overall I think this logic needs to be simplified here, right now is quite hard to read and as @0xnm mentioned I am not sure you need all this logic

In the end the problem that you are trying to solve is to get the bounds of a drawable depending on its parent (view) global bounds + padding + position (left, right, top, bottom) . I think you can find a cleaner logic to achieve this.

I've simplified and moved the bounds logic into ViewUtilsInternal

much much better this way, tks !!

I like this and is quite scalable

I would also suggest to convert index to enum in this method instead of doing it inside createImageWireframe, this has several advantages:

• we don't use index in the createImageWireframe, it removes confusion because when inside createImageWireframe it is not clear what is the index.
• createImageWireframe signature is cleaner, it will get an enum.
• it will remove the need for CompoundDrawablePositions to have position property, because you can create it right in the beginning of the forEachIndexed lambda in the following way:

val drawablePosition = when(index) {
   0 -> ...
   1 -> ...
   ...
}

since it will be close to the comment describing compoundDrawables property, it will be clear what is the index.

I understand the confusion here - this is a different index. The index for compoundDrawable represents the left, top, right, bottom drawable, however the index for createImageWireframe represents the index of the wireframe in the stack of wireframes. Since we are creating potentially multiple imagewireframes off the same view we need a way to generate unique ids for each wireframe to avoid collisions - this can be seen in line39 of imageWireframeHelper where the index is appended to the resolveChildUniqueIdentifier call.

Then still maybe it is better to remove this confusion, because here https://github.com/DataDog/dd-sdk-android/pull/1592/files#diff-7870c4af39004135266ff0b27eb0e6ee96774f0443572f43f1225b716dc9a0d3R80 it is still 0 to left, etc. So we can create enum in the current method, and let then index to be used in createImageWireframe only for ID generation.