Skip to content

Unregister process lifecycle monitor in core instance stop#1589

Merged
mariusc83 merged 1 commit into
developfrom
nogorodnikov/unregister-process-lifecycle-monitor-in-core-instance-stop
Aug 25, 2023
Merged

Unregister process lifecycle monitor in core instance stop#1589
mariusc83 merged 1 commit into
developfrom
nogorodnikov/unregister-process-lifecycle-monitor-in-core-instance-stop

Conversation

@0xnm

@0xnm 0xnm commented Aug 25, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Minor improvement: SDK instance can be stopped, so we should unregister process lifecycle monitor.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner August 25, 2023 12:50
@mariusc83
mariusc83 merged commit 9b9a19c into develop Aug 25, 2023
@mariusc83
mariusc83 deleted the nogorodnikov/unregister-process-lifecycle-monitor-in-core-instance-stop branch August 25, 2023 13:08
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants