Add multiple instance sample#1587
Merged
Merged
Conversation
0xnm
previously approved these changes
Aug 24, 2023
xgouchet
force-pushed
the
xgouchet/poc/library
branch
from
August 24, 2023 13:11
64918e1 to
853622f
Compare
0xnm
previously approved these changes
Aug 24, 2023
xgouchet
force-pushed
the
xgouchet/poc/library
branch
from
August 25, 2023 07:27
853622f to
624ea24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1587 +/- ##
===========================================
- Coverage 83.56% 83.51% -0.05%
===========================================
Files 443 443
Lines 15100 15100
Branches 2258 2258
===========================================
- Hits 12618 12610 -8
- Misses 1883 1892 +9
+ Partials 599 598 -1 🚀 New features to boost your workflow:
|
0xnm
reviewed
Aug 25, 2023
xgouchet
force-pushed
the
xgouchet/poc/library
branch
from
August 25, 2023 07:58
624ea24 to
2feb9b3
Compare
0xnm
approved these changes
Aug 25, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm! just one comment about dependencies.
Comment on lines
+77
to
+78
| implementation(project(":features:dd-sdk-android-trace")) | ||
| implementation(project(":integrations:dd-sdk-android-okhttp")) |
Member
There was a problem hiding this comment.
these 2 seems not to be used as well.
mariusc83
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a fake vendor library creating its own named Datadog instance.
Motivation
The goal is to verify and showcase how library maintainers can use named Datadog instance.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)