Skip to content

RUM-346 Collect the batch_closed telemetry#1586

Merged
mariusc83 merged 1 commit into
developfrom
mconstantin/rum-346/collect-batch-closed-telemetry
Aug 24, 2023
Merged

RUM-346 Collect the batch_closed telemetry#1586
mariusc83 merged 1 commit into
developfrom
mconstantin/rum-346/collect-batch-closed-telemetry

Conversation

@mariusc83

@mariusc83 mariusc83 commented Aug 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

In this PR we are following up on the already merged PR in the dd-sdk-ios repository in which we are sending a special batch_closed telemetry log whenever a batch was closed and prepared for upload in the core. More details in this RFC.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Aug 24, 2023
@mariusc83
mariusc83 force-pushed the mconstantin/rum-346/collect-batch-closed-telemetry branch from 05cfe10 to 755d6a3 Compare August 24, 2023 09:51
@mariusc83
mariusc83 force-pushed the mconstantin/rum-346/collect-batch-closed-telemetry branch from 755d6a3 to 9a199ec Compare August 24, 2023 09:56
@mariusc83
mariusc83 marked this pull request as ready for review August 24, 2023 10:00
@mariusc83
mariusc83 requested a review from a team as a code owner August 24, 2023 10:00
@codecov-commenter

codecov-commenter commented Aug 24, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1586 (9a199ec) into develop (2b41ee8) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 91.67%.

@@            Coverage Diff            @@
##           develop    #1586    +/-   ##
=========================================
  Coverage    83.54%   83.54%            
=========================================
  Files          437      443     +6     
  Lines        14977    15100   +123     
  Branches      2240     2258    +18     
=========================================
+ Hits         12512    12615   +103     
- Misses        1871     1883    +12     
- Partials       594      602     +8
Files Changed Coverage Δ
...roid/core/internal/data/upload/NoOpDataUploader.kt 0.00% <0.00%> (ø)
...tadog/android/core/internal/persistence/Storage.kt 100.00% <ø> (ø)
...d/core/internal/data/upload/v2/NoOpDataUploader.kt 50.00% <50.00%> (ø)
...core/internal/data/upload/v2/DataUploadRunnable.kt 96.67% <71.43%> (-3.33%) ⬇️
...dog/android/core/internal/metrics/RemovalReason.kt 75.00% <75.00%> (ø)
...al/persistence/file/batch/BatchFileOrchestrator.kt 94.90% <86.36%> (+0.62%) ⬆️
...in/com/datadog/android/core/internal/SdkFeature.kt 89.66% <89.66%> (-1.43%) ⬇️
.../android/core/internal/data/upload/UploadStatus.kt 98.25% <95.24%> (-1.75%) ⬇️
...id/core/internal/metrics/BatchMetricsDispatcher.kt 96.43% <96.43%> (ø)
.../internal/configuration/DataUploadConfiguration.kt 100.00% <100.00%> (ø)
... and 6 more

... and 11 files with indirect coverage changes

ncreated
ncreated approved these changes Aug 24, 2023
View reviewed changes

@ncreated ncreated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the metric definition 👍 🚀

@mariusc83
mariusc83 merged commit 199513c into develop Aug 24, 2023
@mariusc83
mariusc83 deleted the mconstantin/rum-346/collect-batch-closed-telemetry branch August 24, 2023 13:25
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncreated ncreated ncreated approved these changes
@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mariusc83 mariusc83

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mariusc83 @codecov-commenter @xgouchet @ncreated @0xnm