RUMM-3508 Add the additionalProperties capability to telemetry debug log event#1575
Merged
mariusc83 merged 1 commit intoAug 16, 2023
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-3508/add-additional-properties-for-telemetry-events
branch
4 times, most recently
from
August 11, 2023 14:31
07c3c39 to
2871266
Compare
mariusc83
marked this pull request as ready for review
August 11, 2023 14:32
mariusc83
force-pushed
the
mconstantin/rumm-3508/add-additional-properties-for-telemetry-events
branch
3 times, most recently
from
August 14, 2023 07:23
3377375 to
5edfc85
Compare
mariusc83
force-pushed
the
mconstantin/rumm-3508/add-additional-properties-for-telemetry-events
branch
from
August 14, 2023 07:57
5edfc85 to
848b519
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1575 +/- ##
===========================================
- Coverage 83.27% 83.25% -0.02%
===========================================
Files 437 437
Lines 14763 14810 +47
Branches 2223 2226 +3
===========================================
+ Hits 12293 12329 +36
- Misses 1881 1891 +10
- Partials 589 590 +1
|
xgouchet
approved these changes
Aug 16, 2023
mariusc83
deleted the
mconstantin/rumm-3508/add-additional-properties-for-telemetry-events
branch
August 16, 2023 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following up on the the latest changes on the telemetry events schema we are adding the capability to add additional properties as a
Map<String,Any?>to our Telemetry debug log events.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)