Skip to content

REPLAY-1895 Remove the query parameters from SR requests#1568

Merged
mariusc83 merged 1 commit into
developfrom
mconstantin/replay-1895/clean-the-sr-request-params
Aug 7, 2023
Merged

REPLAY-1895 Remove the query parameters from SR requests#1568
mariusc83 merged 1 commit into
developfrom
mconstantin/replay-1895/clean-the-sr-request-params

Conversation

@mariusc83

Copy link
Copy Markdown
Member

What does this PR do?

In this PR we align with the Session Replay payload upload request format in iOS by dropping the query parameters.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
mariusc83 requested a review from a team as a code owner August 7, 2023 09:34
@mariusc83 mariusc83 self-assigned this Aug 7, 2023

@ncreated ncreated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mariusc83
mariusc83 merged commit 0d85e50 into develop Aug 7, 2023
@mariusc83
mariusc83 deleted the mconstantin/replay-1895/clean-the-sr-request-params branch August 7, 2023 11:01
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants