Skip to content

[RUMM-3449] Add sample rate to reported RUM events#1566

Merged
plousada merged 1 commit into
developfrom
plousada/RUMM-3449/report_rum_sample_rate
Aug 7, 2023
Merged

[RUMM-3449] Add sample rate to reported RUM events#1566
plousada merged 1 commit into
developfrom
plousada/RUMM-3449/report_rum_sample_rate

Conversation

@plousada

@plousada plousada commented Aug 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Adds the configured RUM sample rate to all reported RUM events.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Aug 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1566 (72ec105) into develop (08ec188) will increase coverage by 0.11%.
The diff coverage is 98.00%.

@@             Coverage Diff             @@
##           develop    #1566      +/-   ##
===========================================
+ Coverage    83.19%   83.30%   +0.11%     
===========================================
  Files          437      437              
  Lines        14750    14777      +27     
  Branches      2223     2224       +1     
===========================================
+ Hits         12271    12309      +38     
+ Misses        1889     1885       -4     
+ Partials       590      583       -7
Files Changed Coverage Δ
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 80.19% <83.33%> (-8.05%) ⬇️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 97.48% <100.00%> (+0.05%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 95.54% <100.00%> (+0.10%) ⬆️
...droid/rum/internal/domain/scope/RumSessionScope.kt 95.45% <100.00%> (+0.05%) ⬆️
...d/rum/internal/domain/scope/RumViewManagerScope.kt 96.97% <100.00%> (+0.09%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.40% <100.00%> (+0.08%) ⬆️

... and 16 files with indirect coverage changes

@plousada
plousada marked this pull request as ready for review August 2, 2023 12:25
@plousada
plousada requested a review from a team as a code owner August 2, 2023 12:25
@plousada
plousada merged commit 9d1bcf8 into develop Aug 7, 2023
@plousada
plousada deleted the plousada/RUMM-3449/report_rum_sample_rate branch August 7, 2023 09:15
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@plousada @codecov-commenter @xgouchet @mariusc83