Skip to content

Remove redundant sqlite product flavour folder in the sample app#1559

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-redundant-sqlite-source-set-folder-in-sample-app
Aug 21, 2023
Merged

Remove redundant sqlite product flavour folder in the sample app#1559
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-redundant-sqlite-source-set-folder-in-sample-app

Conversation

@0xnm

@0xnm 0xnm commented Jul 28, 2023

Copy link
Copy Markdown
Member

What does this PR do?

There is no sqlite flavour anymore in the sample app, so this folder can be removed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner July 28, 2023 12:26
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1559 (0ec0069) into develop (a898f20) will increase coverage by 0.12%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1559      +/-   ##
===========================================
+ Coverage    83.21%   83.32%   +0.12%     
===========================================
  Files          437      437              
  Lines        14749    14749              
  Branches      2220     2220              
===========================================
+ Hits         12272    12289      +17     
+ Misses        1889     1879      -10     
+ Partials       588      581       -7     

see 17 files with indirect coverage changes

@0xnm
0xnm force-pushed the nogorodnikov/remove-redundant-sqlite-source-set-folder-in-sample-app branch from 0ec0069 to 7b57bdc Compare August 21, 2023 12:46
@0xnm
0xnm merged commit 3bcb7ae into develop Aug 21, 2023
@0xnm
0xnm deleted the nogorodnikov/remove-redundant-sqlite-source-set-folder-in-sample-app branch August 21, 2023 13:06
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants