RUMM-3476: Remove dd-sdk-android-ktx module#1555
Merged
0xnm merged 2 commits intoJul 26, 2023
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rumm-3476/remove-dd-sdk-android-ktx-module
branch
from
July 25, 2023 09:41
bcc9bb5 to
56d8a4a
Compare
0xnm
force-pushed
the
nogorodnikov/rumm-3476/remove-dd-sdk-android-ktx-module
branch
from
July 25, 2023 09:43
56d8a4a to
d0f2e05
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1555 +/- ##
===========================================
- Coverage 83.36% 83.32% -0.04%
===========================================
Files 437 437
Lines 14749 14749
Branches 2220 2220
===========================================
- Hits 12295 12289 -6
- Misses 1868 1876 +8
+ Partials 586 584 -2
|
mariusc83
approved these changes
Jul 25, 2023
rtrieu
approved these changes
Jul 25, 2023
rtrieu
left a comment
rtrieu
left a comment
Contributor
There was a problem hiding this comment.
Added a small non-blocking suggestion. Otherwise, it looks good!
Co-authored-by: Rosa Trieu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are removing
dd-sdk-android-ktxmodule to have a better granularity, because code there had a dependency on both RUM and Trace (which are independent modules).Code was re-arranged between the other modules (mostly merged into
dd-sdk-android-rumanddd-sdk-android-tracemodules), but for the coroutines-related code new modules were created:dd-sdk-android-trace-coroutinesanddd-sdk-android-rum-coroutines.Some docs from removed
READMEfile were moved todocumentationrepo in commit DataDog/documentation@94d7156 for the code which was moved todd-sdk-android-rum/dd-sdk-android-tracemodules.Review checklist (to be filled by reviewers)