RUMM-3475: Fix memory leak in JankStats usage#1553
Merged
Conversation
mariusc83
approved these changes
Jul 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1553 +/- ##
===========================================
- Coverage 83.39% 83.31% -0.08%
===========================================
Files 437 437
Lines 14746 14749 +3
Branches 2219 2220 +1
===========================================
- Hits 12297 12287 -10
- Misses 1868 1872 +4
- Partials 581 590 +9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is a memory leak in the structure like
WeakHashMap<Window, JankStats>, becauseWeakHashMaphas strongly-referenced values, so it means ifJankStatsholds internallyWindowinstance, it won't be GC-ed, even if it is a key ofWeakHashMap.In this PR we are removing the keys explicitly if activity is destroyed and there are no more activities left. This may increase the number of times we create
JankStatsinstance, but it is not a big deal compared to the memory leak mitigation.Even if there is a configuration change and activity will be re-created, it may be backed by new/another window anyway.
Review checklist (to be filled by reviewers)