Skip to content

RUMM-3465: Update documentation for SDK v2#1549

Merged
0xnm merged 2 commits into
developfrom
nogorodnikov/rumm-3465/update-documentation
Jul 24, 2023
Merged

RUMM-3465: Update documentation for SDK v2#1549
0xnm merged 2 commits into
developfrom
nogorodnikov/rumm-3465/update-documentation

Conversation

@0xnm

@0xnm 0xnm commented Jul 18, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This PR updates documentation in the repository to be aligned with actual changes made for SDK v2.

Documentation in https://github.com/DataDog/documentation repository will be update in another PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm force-pushed the nogorodnikov/rumm-3465/update-documentation branch from 4f55b58 to b395ae7 Compare July 18, 2023 11:59
@codecov-commenter

codecov-commenter commented Jul 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1549 (4cdcafc) into develop (842da6c) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1549      +/-   ##
===========================================
- Coverage    83.50%   83.40%   -0.09%     
===========================================
  Files          438      438              
  Lines        14877    14877              
  Branches      2246     2246              
===========================================
- Hits         12422    12408      -14     
- Misses        1869     1886      +17     
+ Partials       586      583       -3     

see 12 files with indirect coverage changes

Comment thread features/dd-sdk-android-ndk/README.md
@0xnm
0xnm marked this pull request as ready for review July 18, 2023 15:35
@0xnm
0xnm requested review from a team as code owners July 18, 2023 15:36
@0xnm
0xnm force-pushed the nogorodnikov/rumm-3465/update-documentation branch from b395ae7 to b41798c Compare July 18, 2023 15:37
Base automatically changed from nogorodnikov/remove-redundant-doc-files to develop July 21, 2023 15:18

@rtrieu rtrieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for consistency, but otherwise looks good!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread dd-sdk-android-core/README.md Outdated
Comment thread dd-sdk-android-core/README.md Outdated
Comment thread dd-sdk-android-core/README.md Outdated
@0xnm
0xnm force-pushed the nogorodnikov/rumm-3465/update-documentation branch from 0fa84dd to 4cdcafc Compare July 24, 2023 08:30
@0xnm
0xnm requested a review from rtrieu July 24, 2023 08:50

@rtrieu rtrieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm
0xnm merged commit 298d2dd into develop Jul 24, 2023
@0xnm
0xnm deleted the nogorodnikov/rumm-3465/update-documentation branch July 24, 2023 16:32
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants