Don't report OkHttp throwables to telemetry#1548
Merged
0xnm merged 1 commit intoJul 17, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1548 +/- ##
===========================================
+ Coverage 83.40% 83.42% +0.01%
===========================================
Files 438 438
Lines 14877 14877
Branches 2246 2246
===========================================
+ Hits 12408 12410 +2
Misses 1873 1873
+ Partials 596 594 -2
|
mariusc83
approved these changes
Jul 17, 2023
xgouchet
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't report OkHttp errors to telemetry, because they can happen quite often (no internet connection) and not actionable.
Review checklist (to be filled by reviewers)