[RUMM-3448] Remove tracking of view loading time and fix unit tests#1545
Merged
Conversation
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
from
July 20, 2023 09:47
7a29fca to
fbd9aef
Compare
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
from
July 20, 2023 11:18
fbd9aef to
bbaa2ae
Compare
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
3 times, most recently
from
July 21, 2023 12:56
0bb0ce2 to
5bd2ca6
Compare
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
from
July 21, 2023 12:56
5bd2ca6 to
294bfd0
Compare
xgouchet
approved these changes
Jul 21, 2023
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
from
July 21, 2023 13:31
471c0fd to
2d7ca96
Compare
plousada
force-pushed
the
plousada/RUMM-3448/remove_view_loading
branch
from
July 21, 2023 13:47
2d7ca96 to
78955db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1545 +/- ##
===========================================
- Coverage 83.55% 83.31% -0.23%
===========================================
Files 438 437 -1
Lines 14877 14746 -131
Branches 2246 2219 -27
===========================================
- Hits 12429 12285 -144
- Misses 1867 1874 +7
- Partials 581 587 +6
|
plousada
marked this pull request as ready for review
July 21, 2023 14:26
xgouchet
approved these changes
Jul 21, 2023
fuzzybinary
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Eliminates
view.loading_timefrom the SDK.Alongside this introduced a view update event following a new view scope creation created via
startViewevent.Motivation
We're removing
view.loading_timeas it was causing customer confusion with its current implementation.We'll rework and re-introduce this feature in a more holistic manner once we come to a product decision.
Additional Notes
I also altered the process priority for Kiosk integration tests in order to align with the other existing scenarios.
Review checklist (to be filled by reviewers)