Skip to content

Don't reexport OkHttp from Glide#1543

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/dont-reexport-okhttp-from-glide
Jul 17, 2023
Merged

Don't reexport OkHttp from Glide#1543
0xnm merged 1 commit into
developfrom
nogorodnikov/dont-reexport-okhttp-from-glide

Conversation

@0xnm

@0xnm 0xnm commented Jul 13, 2023

Copy link
Copy Markdown
Member

What does this PR do?

There are no OkHttp symbols in the public API of Glide integration module, so no need to re-export it.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner July 13, 2023 15:55
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1543 (7f1e4bc) into develop (a0b843c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
+ Coverage    83.41%   83.45%   +0.04%     
===========================================
  Files          438      438              
  Lines        14872    14877       +5     
  Branches      2242     2246       +4     
===========================================
+ Hits         12405    12415      +10     
+ Misses        1881     1873       -8     
- Partials       586      589       +3     
Impacted Files Coverage Δ
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.49% <100.00%> (+0.98%) ⬆️

... and 11 files with indirect coverage changes

@0xnm
0xnm merged commit b729f76 into develop Jul 17, 2023
@0xnm
0xnm deleted the nogorodnikov/dont-reexport-okhttp-from-glide branch July 17, 2023 07:46
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants