REPLAY-1894: Remove explicit dependency on RUM module from Session Replay#1541
Merged
0xnm merged 1 commit intoJul 17, 2023
Conversation
xgouchet
approved these changes
Jul 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1541 +/- ##
===========================================
+ Coverage 83.41% 83.47% +0.06%
===========================================
Files 438 438
Lines 14872 14877 +5
Branches 2242 2246 +4
===========================================
+ Hits 12405 12418 +13
+ Misses 1881 1877 -4
+ Partials 586 582 -4
|
plousada
approved these changes
Jul 13, 2023
mariusc83
approved these changes
Jul 17, 2023
0xnm
deleted the
nogorodnikov/replay-1894/remove-dependency-on-rum-from-session-replay
branch
July 17, 2023 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We were using just few symbols from RUM module, and they probably even are not needed.
This change is to have the consistency in the setup with iOS SDK, where
DatadogRUMshould be added alongside with Session Replay module.Review checklist (to be filled by reviewers)