RUMM-3445: Support navHost hosted by FragmentContainerView for NavigationViewTrackingStrategy#1538
Merged
0xnm merged 1 commit intoJul 13, 2023
Conversation
…tionViewTrackingStrategy
Codecov Report
@@ Coverage Diff @@
## develop #1538 +/- ##
===========================================
- Coverage 83.45% 83.42% -0.03%
===========================================
Files 438 438
Lines 14867 14872 +5
Branches 2239 2243 +4
===========================================
Hits 12406 12406
Misses 1879 1879
- Partials 582 587 +5
|
mariusc83
approved these changes
Jul 13, 2023
xgouchet
approved these changes
Jul 13, 2023
0xnm
deleted the
nogorodnikov/rumm-3445/support-nav-host-wrapped-in-fragment-container-view
branch
July 13, 2023 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the issue described here. Basically now the recommendation is to use
FragmentContainerViewfor hostingNavHostFragment, this now will be the priority for lookup, and if not found we fall back to the old strategy.Review checklist (to be filled by reviewers)