RUMM-3338: Introduce known file cache and cleanup throttling in BatchFileOrchestrator in order to reduce the number of syscalls#1506
Merged
0xnm merged 1 commit intoJun 30, 2023
Conversation
…FileOrchestrator in order to reduce the number of syscalls
0xnm
force-pushed
the
nogorodnikov/rumm-3338/optimize-batch-file-orchestrator
branch
from
June 28, 2023 15:44
b203a62 to
9538a69
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1506 +/- ##
===========================================
+ Coverage 82.00% 82.07% +0.07%
===========================================
Files 363 363
Lines 12981 12995 +14
Branches 2162 2165 +3
===========================================
+ Hits 10645 10665 +20
+ Misses 1679 1676 -3
+ Partials 657 654 -3
|
0xnm
marked this pull request as ready for review
June 29, 2023 07:48
xgouchet
approved these changes
Jun 29, 2023
| } | ||
|
|
||
| deleteObsoleteFiles() | ||
| lastCleanupTimestamp = System.currentTimeMillis() |
Contributor
There was a problem hiding this comment.
maybe the update of lastCleanupTimestamp can be part of the deleteObsoleteFiles() method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The goal of this PR is to reduce CPU consumption during the scenarios like described in #1469.
The issue comes from the fact that when we have many batch files on the disk calling
listSortedBatchFilesas-is (which is called several times duringgetWritableFile, for example) becomes quite expensive because:isFile) are expensiveIn order to optimize that, the following is done:
isFileand use regex.getWritableFilepath, because a) it can be called much more often thangetReadableFile, for every event; b) cleanup actions are a bit different betweengetReadableFileandgetWritableFile, so having the same timestamp is not quite correct).Test scenario: 300 batch files on the disk, disabled network, writing 1 log entry every 100 ms.
CPU usage after the change (same scenario and duration is used):
It gives a very good bump if the total number files on the disk is below the cache max size. If cache is not enough, the problem comes back (but maybe in a bit better state, because we have cleanup throttling)
CPU usage before the change:
Review checklist (to be filled by reviewers)