RUMM-3314: Keep old viewIds for view scope#1448
Merged
0xnm merged 2 commits intoJun 2, 2023
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rumm-3314/keep-old-viewId-for-view-scope
branch
from
June 1, 2023 15:28
0815e25 to
53c1033
Compare
0xnm
force-pushed
the
nogorodnikov/rumm-3314/keep-old-viewId-for-view-scope
branch
from
June 1, 2023 15:42
53c1033 to
7945b0f
Compare
Codecov Report
@@ Coverage Diff @@
## nogorodnikov/rumm-3313/set-last-interaction-time-by-sdkinit-event #1448 +/- ##
=====================================================================================================
- Coverage 82.05% 82.00% -0.05%
=====================================================================================================
Files 363 363
Lines 12988 12991 +3
Branches 2165 2165
=====================================================================================================
- Hits 10657 10653 -4
+ Misses 1676 1674 -2
- Partials 655 664 +9
|
0xnm
changed the base branch from
nogorodnikov/rumm-3313/set-last-interaction-time-by-sdkinit-event
to
develop
June 2, 2023 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to keep old RUM view scope IDs, because
viewIdcan be changed on the session renewal, meaning that events likeActionSent, etc. which do the match byviewIdwon't match, because they will carry oldviewId.Review checklist (to be filled by reviewers)