Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1433 +/- ##
===========================================
+ Coverage 81.94% 82.01% +0.07%
===========================================
Files 363 363
Lines 13031 13033 +2
Branches 2191 2193 +2
===========================================
+ Hits 10677 10688 +11
+ Misses 1688 1682 -6
+ Partials 666 663 -3
🚀 New features to boost your workflow:
|
mariusc83
approved these changes
May 24, 2023
xgouchet
approved these changes
May 24, 2023
0xnm
deleted the
nogorodnikov/rumm-3305/ignore-adding-custom-timings-and-feature-flags-for-the-stopped-view
branch
May 24, 2023 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes #1432:
RumViewScopewas accepting custom timings and feature flags in thestoppedstate, allowing them to be added to the multiple views at the same time (because we keep some views inRumViewManagerScopeuntil their child events complete).This PR adds the necessary check requiring the view to be active to add such information, and this aligns with the logic in the iOS SDK for the custom timings and feature flags.
Review checklist (to be filled by reviewers)