Force new session at sdk initialization#1399
Merged
Merged
Conversation
plousada
force-pushed
the
plousada/RUMM-3068/start_session_on_sdk_init
branch
from
April 24, 2023 17:09
43a9fe5 to
60eda0d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1399 +/- ##
===========================================
+ Coverage 82.01% 82.04% +0.03%
===========================================
Files 363 363
Lines 13021 13032 +11
Branches 2188 2191 +3
===========================================
+ Hits 10678 10691 +13
+ Misses 1685 1682 -3
- Partials 658 659 +1
|
xgouchet
approved these changes
Apr 25, 2023
0xnm
approved these changes
Apr 25, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm! I've added a comment about redundant line.
Introduces an SdkInit event at the initialization of RumMonitor in order to make sure a session is started before the first interaction is recorded. This makes it so that logs and traces correlated when correlated with RUM, have a valid session id present at all times.
plousada
force-pushed
the
plousada/RUMM-3068/start_session_on_sdk_init
branch
from
April 26, 2023 12:16
60eda0d to
26829b7
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the SdkInit event at the initialization of RumMonitor in order to make sure a session is started before the first RUM interaction.
This makes it so that logs and traces are correctly correlated to a valid session if they occur before the first view or action takes place.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)