RUMM-3194 add tracer sampling rate#1393
Merged
Merged
Conversation
0xnm
approved these changes
Apr 18, 2023
| * Sets the sampling rate of spans. | ||
| * @param samplingRate the sampling rate as a percentage between 0 and 100 (default is 100%) | ||
| */ | ||
| fun setSamplingRate(samplingRate: Double): Builder { |
Member
There was a problem hiding this comment.
we can also add FloatRange annotation for the clarity.
Contributor
Author
There was a problem hiding this comment.
Makes sense indeed
xgouchet
force-pushed
the
xgouchet/RUMM-3194/add_tracer_sampling_rate
branch
from
April 18, 2023 12:03
9b90797 to
2edc280
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1393 +/- ##
===========================================
- Coverage 82.00% 81.96% -0.04%
===========================================
Files 363 363
Lines 13015 13021 +6
Branches 2188 2188
===========================================
Hits 10672 10672
- Misses 1683 1684 +1
- Partials 660 665 +5
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a sampling rate for local traces. The sampling will be applied automatically to the root span if it's not set manually on it.