Fix stopped RUMViewManager from being able to start new views.#1381
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1381 +/- ##
===========================================
- Coverage 81.93% 81.88% -0.05%
===========================================
Files 363 363
Lines 13014 13015 +1
Branches 2187 2188 +1
===========================================
- Hits 10663 10657 -6
+ Misses 1686 1685 -1
- Partials 665 673 +8
|
0xnm
approved these changes
Apr 13, 2023
xgouchet
approved these changes
Apr 13, 2023
mariusc83
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stopping a session leaves the session in the list of child scopes until the session is done with all of its work (Resources and user actions are stopped). If a StartView event happens while that session is stopped but still processing events, it was incorrectly being created in the stopped ViewManagerScope.
Additional Notes
I double checked Resources and Actions in the ViewScope and those should be safe, as they are only created if the view is active (and stopping the session stops the active view)
Review checklist (to be filled by reviewers)