Fix telemetry sampling internal configuration for Flutter#1326
Merged
Conversation
maciejburda
approved these changes
Mar 7, 2023
0xnm
approved these changes
Mar 7, 2023
xgouchet
approved these changes
Mar 7, 2023
Flutter sends the telemetry configuration sample rate as a Double, not a Float. Use Number instead.
fuzzybinary
force-pushed
the
jward/minor-telemetry-fix
branch
from
March 8, 2023 15:18
5db5979 to
5270ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Flutter sends the telemetry configuration sample rate as a Double, not a Float. Use Number instead.
Review checklist (to be filled by reviewers)