Skip to content

[RUMM-2936] Alter public API of Logger to receive Any data type#1324

Merged
plousada merged 2 commits into
feature/sdkv2from
plousada/RUMM-2936/logger-any-attribute
Mar 7, 2023
Merged

[RUMM-2936] Alter public API of Logger to receive Any data type#1324
plousada merged 2 commits into
feature/sdkv2from
plousada/RUMM-2936/logger-any-attribute

Conversation

@plousada

@plousada plousada commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Simplify public API of Logger by receiving Any? value for attributes.
All the necessary underlying code to support this was already in place.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada
plousada requested a review from a team as a code owner March 6, 2023 15:26
@plousada
plousada force-pushed the plousada/RUMM-2936/logger-any-attribute branch 2 times, most recently from 47032c7 to 8991777 Compare March 6, 2023 17:11
@plousada
plousada force-pushed the plousada/RUMM-2936/logger-any-attribute branch from 8991777 to 89e5a03 Compare March 7, 2023 09:09
@codecov-commenter

codecov-commenter commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1324 (4fb519c) into feature/sdkv2 (5fcb32e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1324      +/-   ##
=================================================
- Coverage          81.83%   81.81%   -0.02%     
=================================================
  Files                369      369              
  Lines              13074    13065       -9     
  Branches            2182     2182              
=================================================
- Hits               10699    10689      -10     
- Misses              1723     1728       +5     
+ Partials             652      648       -4
Impacted Files Coverage Δ
.../src/main/kotlin/com/datadog/android/log/Logger.kt 97.64% <100.00%> (-0.16%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 90.91% <0.00%> (-6.82%) ⬇️
...e/internal/domain/event/DdSpanToSpanEventMapper.kt 95.83% <0.00%> (-4.17%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 75.52% <0.00%> (-2.80%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 94.74% <0.00%> (-2.63%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 90.76% <0.00%> (-0.54%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 83.83% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.94% <0.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.86% <0.00%> (+1.36%) ⬆️
... and 2 more

@plousada
plousada force-pushed the plousada/RUMM-2936/logger-any-attribute branch from c029756 to d2c7314 Compare March 7, 2023 11:01
@plousada
plousada merged commit 2e2f7f0 into feature/sdkv2 Mar 7, 2023
@plousada
plousada deleted the plousada/RUMM-2936/logger-any-attribute branch March 7, 2023 12:46
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@plousada @codecov-commenter @xgouchet @0xnm