Skip to content

Update RUM Telemetry event schema to latest#1319

Merged
fuzzybinary merged 2 commits into
developfrom
jward/update-rum-schema
Mar 8, 2023
Merged

Update RUM Telemetry event schema to latest#1319
fuzzybinary merged 2 commits into
developfrom
jward/update-rum-schema

Conversation

@fuzzybinary

@fuzzybinary fuzzybinary commented Mar 6, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Update the RUM Telemetry event schema to the latest version.

Motivation

This was mostly wanted for the new React Version and Dart Version fields, but it looks like some other properties may have been changed / added recently.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary
fuzzybinary requested a review from a team as a code owner March 6, 2023 14:41
@fuzzybinary
fuzzybinary force-pushed the jward/update-rum-schema branch 2 times, most recently from 66e4f1a to ca46ac9 Compare March 6, 2023 19:08
@codecov-commenter

codecov-commenter commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1319 (ca46ac9) into develop (e614b64) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1319      +/-   ##
===========================================
+ Coverage    81.95%   81.98%   +0.03%     
===========================================
  Files          362      362              
  Lines        12892    12892              
  Branches      2163     2163              
===========================================
+ Hits         10565    10569       +4     
+ Misses        1669     1668       -1     
+ Partials       658      655       -3
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 71.43% <0.00%> (-14.29%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 94.44% <0.00%> (-2.78%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 94.74% <0.00%> (-2.63%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.09% <0.00%> (-1.56%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-0.86%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 88.89% <0.00%> (-0.53%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.51% <0.00%> (+0.17%) ⬆️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 85.06% <0.00%> (+0.41%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 86.92% <0.00%> (+1.54%) ⬆️
...al/persistence/file/batch/BatchFileOrchestrator.kt 95.28% <0.00%> (+1.57%) ⬆️
... and 2 more

@fuzzybinary
fuzzybinary force-pushed the jward/update-rum-schema branch from ca46ac9 to a6b4fee Compare March 8, 2023 15:18
@fuzzybinary
fuzzybinary merged commit ccd1548 into develop Mar 8, 2023
@fuzzybinary
fuzzybinary deleted the jward/update-rum-schema branch March 8, 2023 16:12
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fuzzybinary @codecov-commenter @xgouchet @0xnm