RUMM-3094 fix unreliable plugged battery info#1315
Merged
xgouchet merged 1 commit intoMar 6, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.17.0 #1315 +/- ##
==================================================
- Coverage 82.11% 81.99% -0.12%
==================================================
Files 361 361
Lines 12832 12833 +1
Branches 2153 2154 +1
==================================================
- Hits 10536 10522 -14
- Misses 1653 1658 +5
- Partials 643 653 +10
|
fuzzybinary
approved these changes
Mar 3, 2023
0xnm
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On some devices (e.g. Fire TV on OS 7.6.2.4), the
BatteryManager.EXTRA_PLUGGEDreturns0, when the device is clearly plugged. Because we only upload tracked data when the device as enough power (battery > 10% or device is plugged), the device doesn't upload anything on those devices.The fix relies on the
BatteryManager.EXTRA_PRESENTthat tells if a battery is present on the device. We can then assume that if the battery is not present, and the device is alive running the app, that it has another power source.