Add internal telemetry configuration sampling rate#1310
Merged
Conversation
xgouchet
approved these changes
Mar 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1310 +/- ##
===========================================
- Coverage 82.01% 81.98% -0.03%
===========================================
Files 362 362
Lines 12857 12868 +11
Branches 2156 2159 +3
===========================================
+ Hits 10544 10549 +5
- Misses 1661 1665 +4
- Partials 652 654 +2
|
0xnm
reviewed
Mar 2, 2023
| internal val sdkCore: SdkCore, | ||
| internal val eventSampler: Sampler, | ||
| internal val configurationExtraSampler: Sampler = RateBasedSampler(20f.percent()), | ||
| internal var configurationExtraSampler: Sampler = RateBasedSampler(20f.percent()), |
Member
There was a problem hiding this comment.
it doesn't need to be var it seems?
Member
Author
There was a problem hiding this comment.
Yes, thanks. I changed it when I thought I would take a different approach but found one that worked better.
0xnm
approved these changes
Mar 2, 2023
This serves as a way for the cross platform SDKs to modify whether telemetry gets sent in order to test our own telemetry logic.
fuzzybinary
force-pushed
the
jward/configuration-telemetry-property
branch
from
March 2, 2023 15:36
7d410a7 to
ad0e926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a property that can be supplied through additionalConfiguration which sets the extra sample rate for configuration telemetry. This serves as a way for the cross platform SDKs to modify whether telemetry gets sent in order to test our own telemetry logic.
Review checklist (to be filled by reviewers)