Skip to content

[DOCS-4392] Add app variant definition in docs#1296

Merged
maycmlee merged 5 commits into
developfrom
may/app-variant-definition
Feb 22, 2023
Merged

[DOCS-4392] Add app variant definition in docs#1296
maycmlee merged 5 commits into
developfrom
may/app-variant-definition

Conversation

@maycmlee

@maycmlee maycmlee commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a sentence to define APP_VARIANT_NAME.

Motivation

DOCS-4292, customer feedback.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@maycmlee maycmlee added the documentation Improvements or additions to documentation label Feb 21, 2023
@maycmlee
maycmlee requested review from a team as code owners February 21, 2023 20:35
alai97
alai97 approved these changes Feb 21, 2023
View reviewed changes

@alai97 alai97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs!

@codecov-commenter

codecov-commenter commented Feb 21, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1296 (f6e0e15) into develop (16543f7) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1296      +/-   ##
===========================================
- Coverage    82.11%   82.02%   -0.09%     
===========================================
  Files          361      361              
  Lines        12832    12832              
  Branches      2153     2153              
===========================================
- Hits         10536    10525      -11     
+ Misses        1653     1652       -1     
- Partials       643      655      +12
Impacted Files Coverage Δ
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 89.00% <0.00%> (-5.00%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 94.74% <0.00%> (-2.63%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 87.69% <0.00%> (-1.54%) ⬇️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.03% <0.00%> (-1.45%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 59.48% <0.00%> (-0.86%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 73.44% <0.00%> (-0.78%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 85.59% <0.00%> (-0.42%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.20% <0.00%> (-0.18%) ⬇️
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.94% <0.00%> (ø)
...al/persistence/file/batch/BatchFileOrchestrator.kt 95.28% <0.00%> (+1.57%) ⬆️
... and 1 more

@maycmlee
maycmlee merged commit c618644 into develop Feb 22, 2023
@maycmlee
maycmlee deleted the may/app-variant-definition branch February 22, 2023 15:06
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+2 more reviewers
@xgouchet xgouchet xgouchet approved these changes
@alai97 alai97 alai97 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@maycmlee @codecov-commenter @xgouchet @0xnm @alai97 @kayayarai