RUMM-2864 add support to AP1#1268
Merged
Merged
Conversation
0xnm
approved these changes
Feb 7, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm! I like the change to switch to remove feature-specific intakes.
xgouchet
force-pushed
the
xgouchet/RUMM-2864/support_ap1
branch
from
February 7, 2023 12:54
c98587a to
db007d7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1268 +/- ##
===========================================
- Coverage 82.01% 81.99% -0.02%
===========================================
Files 361 361
Lines 12832 12820 -12
Branches 2149 2146 -3
===========================================
- Hits 10524 10511 -13
- Misses 1655 1656 +1
Partials 653 653
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support to the AP1 (Japan) datacenter
Additional Notes
We also use subdomainless endpoints, which are not necessary since API v2 where the track is part of the path.