RUMM-2900 make tests more accurate with url case sensitivity#1263
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1263 +/- ##
===========================================
- Coverage 82.01% 81.91% -0.10%
===========================================
Files 361 361
Lines 12832 12832
Branches 2149 2149
===========================================
- Hits 10524 10511 -13
- Misses 1655 1660 +5
- Partials 653 661 +8
|
0xnm
approved these changes
Feb 3, 2023
plousada
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We used to require all urls to be fully lowercase in our tests assertions, as case sensitivity used to make the tests fail.
After investigation, we noticed that OKHttp automatically standardize the host name to be all lowercasen because the host name by definition (RFC-4343).
This PR updates our test to follow closely this principle and OkHttp behavior, by forging random URLs with a lowercase hostname, and a path that is still case sensitive.