RUMM-2903 detect device's refresh rate from vital monitor#1251
Merged
Conversation
plousada
approved these changes
Jan 26, 2023
xgouchet
force-pushed
the
xgouchet/RUMM-2903/detect_refresh_rate
branch
2 times, most recently
from
January 26, 2023 14:32
da40b01 to
9d07a74
Compare
xgouchet
force-pushed
the
xgouchet/RUMM-2903/detect_refresh_rate
branch
from
January 26, 2023 14:59
9d07a74 to
1fa842a
Compare
0xnm
approved these changes
Jan 26, 2023
| const val TEN_SECOND_NS: Long = 10L * ONE_SECOND_NS | ||
| const val ONE_MINUTE_NS: Long = 60L * ONE_SECOND_NS | ||
|
|
||
| val logger = InternalLoggerTestConfiguration() |
Member
There was a problem hiding this comment.
seems we don't need this one, because there are no tests checking logger invocations.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure we detect the device's refresh rate with any ViewTrackingStrategy
Motivation
The previous implementation didn't work with the NavigationViewTrackingStrategy
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)