RUMM-2931 prevent reporting ANR when app is in background#1239
Merged
Conversation
xgouchet
marked this pull request as ready for review
January 18, 2023 14:07
Codecov Report
@@ Coverage Diff @@
## develop #1239 +/- ##
===========================================
+ Coverage 82.50% 82.53% +0.04%
===========================================
Files 353 353
Lines 11832 11833 +1
Branches 2015 2016 +1
===========================================
+ Hits 9761 9766 +5
+ Misses 1461 1460 -1
+ Partials 610 607 -3
|
0xnm
approved these changes
Jan 18, 2023
mariusc83
approved these changes
Jan 18, 2023
emartynov
reviewed
Jan 18, 2023
| // Given | ||
| testedScope.applicationDisplayed = true | ||
| val fakeEvent = RumRawEvent.AddError( | ||
| message = ANRDetectorRunnable.ANR_MESSAGE, |
There was a problem hiding this comment.
Probably off topic - from names ANRDetectorRunnable.ANR_MESSAGE and ANRException I can not draw an understanding that it is a background ANR.
There was a problem hiding this comment.
Also, testedScope has applicationDisplayed as true, which sounds to me as if it is not in the background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1067
This PR prevents reporting false positive ANRs when the application is in background.
Motivation
In some cases (#1067) the host application is in background and the SDK detekts multiple SDKs that are not actually perceived by the end user.