Skip to content

Remove Session Replay from public API#1235

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/sdkv2_no-session-replay
Jan 18, 2023
Merged

Remove Session Replay from public API#1235
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/sdkv2_no-session-replay

Conversation

@0xnm

@0xnm 0xnm commented Jan 17, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Temporary commit to remove Session Replay from the public API. It will be reverted shortly after, needed to do the SDK v2 content merge into develop branch.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 17, 2023 16:42
@codecov-commenter

codecov-commenter commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.81%. Comparing base (9894418) to head (e27490f).

Additional details and impacted files 
@@                Coverage Diff                @@
##           feature/sdkv2    #1235      +/-   ##
=================================================
+ Coverage          82.74%   82.81%   +0.08%     
=================================================
  Files                358      358              
  Lines              12628    12579      -49     
  Branches            2101     2091      -10     
=================================================
- Hits               10448    10417      -31     
+ Misses              1525     1524       -1     
+ Partials             655      638      -17
Files with missing lines Coverage Δ
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 77.36% <ø> (+2.81%) ⬆️
...main/kotlin/com/datadog/android/DatadogEndpoint.kt 0.00% <ø> (ø)
...src/main/kotlin/com/datadog/android/DatadogSite.kt 100.00% <ø> (+13.33%) ⬆️
...atadog/android/core/configuration/Configuration.kt 98.46% <100.00%> (-0.13%) ⬇️
.../main/kotlin/com/datadog/android/plugin/Feature.kt 100.00% <100.00%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 85.59% <ø> (-0.29%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit d0e75f7 into feature/sdkv2 Jan 18, 2023
@0xnm
0xnm deleted the nogorodnikov/sdkv2_no-session-replay branch January 18, 2023 09:32
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83